-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tool allowing changing number of __consumer_offsets
topic partitions
#7604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think it would be better to use an import
/export
feature from the kafka CLI tooling or even from kcl if it exists? i dunno if it exists or not, but it seems like something that might.
I was asked to provide a script that does not depend on any other tools |
2dbd01b
to
3d1b916
Compare
__consumer_offsets
topic partitions
Introduced tool that may be helpful when dealing with consumer offsets topic issue. The tool is designed to make changing the `__consumer_offsets` topic partition count. It can be also used to restore consumer group state. Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
3d1b916
to
34e3ff2
Compare
Pasting the console output for future reference. Just curious if we can suppress the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if i == 0: | ||
group = l.strip() | ||
if not dry_run: | ||
consumer = KafkaConsumer(group_id=group, **cfg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: No need to check if i is 0 within the loop, can just initialize consumer before for
loop and perform some error checking against the value of the first line in the file.
from rptest.services.redpanda import RedpandaService | ||
|
||
|
||
class ConsumerOffsetsRecovery: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super +1
Introduced tool that may be helpful when dealing with consumer offsets topic issue. The tool is designed to make changing the
__consumer_offsets
topic partition count. It can be also used to restore consumer group state.Signed-off-by: Michal Maslanka michal@redpanda.com
Backports Required
UX Changes
Release Notes
Features
__consumer_offsets
topic