tools: fixed incorrect parsing of some controller commands #7814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
requested review from
gousteris and
jcsp
and removed request for
a team
jcsp
previously approved these changes
Dec 16, 2022
mmaslankaprv
force-pushed
the
improved-offline-log-viewer
branch
from
e445183
to
2a2ac2e
Compare
jcsp
previously approved these changes
Dec 16, 2022
mmaslankaprv
force-pushed
the
improved-offline-log-viewer
branch
from
2a2ac2e
to
958820c
Compare
jcsp
previously approved these changes
Dec 16, 2022
mmaslankaprv
force-pushed
the
improved-offline-log-viewer
branch
from
958820c
to
a162d18
Compare
Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
improved-offline-log-viewer
branch
from
a162d18
to
428a488
Compare
jcsp
approved these changes
Dec 20, 2022
|
@mmaslankaprv it probably doesn't require it right away (I don't think our upgrade tests touch these particular commands yet?), but as+when we do, for CDT tests to pick this up we need vtools commits like https://github.com/redpanda-data/vtools/pull/1200. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed incorrect parsing of some controller commands in
tools/offline_log_viewer. Current implementation supports reading all of the commandsBackports Required
UX Changes
Release Notes