k/group_metadata: added support for v1 offset metadata value #7923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redpanda maintains on disk format compatibility with Kafka for `__consumer_offsets` topic messages. Added support for `expiry_timestamp` field that was part of `OffsetCommitValue` version 1. Previously redpanda implementation defaulted to the most recent version 3. Expiry timestamp may be set by clients using older versions of `OffsetCommit` requests. To maintain compatibility we must persist the value for older messages. Signed-off-by: Michal Maslanka <michal@redpanda.com>
| writer.write(v.metadata); | ||
| writer.write(v.commit_timestamp); | ||
| if (v.version == group_metadata_version{1}) { | ||
| writer.write(v.expiry_timestamp); |
There was a problem hiding this comment.
Question, could there ever be an issue with compatibility across versions because we were always deserializing this int64 value but never serializing it?
There was a problem hiding this comment.
not really since we only deserializing this for version == 1
graphcareful
approved these changes
Dec 23, 2022
|
Failure is flippy test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redpanda maintains on disk format compatibility with Kafka for
__consumer_offsetstopic messages. Added support forexpiry_timestampfield that was part ofOffsetCommitValueversion 1. Previously redpanda implementation defaulted to the most recent version 3.Expiry timestamp may be set by clients using older versions of
OffsetCommitrequests. To maintain compatibility we must persist the value for older messages.Backports Required
UX Changes
Release Notes