Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add feeclaim_xxx address parsing #648

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 7, 2023

Description

Parser missing for feeclaim addresses

Motivation and Context

feeclaim_ substate addresses are parsable from a string.

How Has This Been Tested?

Very minor fix, not explicitly tested

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Test Results (CI)

127 tests  +18   127 ✔️ +26   1h 11m 20s ⏱️ - 10m 10s
  42 suites +  9       0 💤 ±  0 
    2 files   +  1       0  -   8 

Results for commit 65d1ea9. ± Comparison against base commit 2651440.

♻️ This comment has been updated with latest results.

@stringhandler stringhandler added this pull request to the merge queue Aug 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 11, 2023
@stringhandler stringhandler added this pull request to the merge queue Aug 11, 2023
@stringhandler stringhandler removed this pull request from the merge queue due to a manual request Aug 11, 2023
@stringhandler stringhandler merged commit d813d8d into tari-project:development Aug 11, 2023
9 checks passed
sdbondi added a commit to sdbondi/tari-dan that referenced this pull request Aug 16, 2023
* development:
  fix!: peer sync (tari-project#657)
  fix(vn/ui): committee bucket information (tari-project#656)
  fix(engine): return engine error from instruction invocation  (tari-project#655)
  fix(walletd): fix race condition causing transaction to be marked as invalid (tari-project#654)
  ci: double test timeout
  fix(vn-webui): fix incorrect jsonrpc address (tari-project#645)
  fix: add feeclaim_xxx address parsing (tari-project#648)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants