fix!: peer sync #657
Merged
fix!: peer sync #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
vn-fix-peer-sync
branch
from
b4d47b3
to
8d32b1c
Compare
Cifko
approved these changes
Aug 15, 2023
stringhandler
approved these changes
Aug 15, 2023
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Aug 16, 2023
* development: fix!: peer sync (tari-project#657) fix(vn/ui): committee bucket information (tari-project#656) fix(engine): return engine error from instruction invocation (tari-project#655) fix(walletd): fix race condition causing transaction to be marked as invalid (tari-project#654) ci: double test timeout fix(vn-webui): fix incorrect jsonrpc address (tari-project#645) fix: add feeclaim_xxx address parsing (tari-project#648)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix peer sync and announce by correctly handling peer signature claims
Motivation and Context
Peer sync and announce worked only when a single address is used, when multiple addresses are added (this happens whenever an address is changed), the identity signature validation fails.
How Has This Been Tested?
100 validator nodes which local address changes on each startup, able to peer sync and receiving valid announces
What process can a PR reviewer use to test or verify this change?
Change the validator node address and check that the network can receive the updated address
Breaking Changes