fix(engine): return engine error from instruction invocation #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
engine-error-details
branch
2 times, most recently
from
b95435f
to
973276b
Compare
sdbondi
force-pushed
the
engine-error-details
branch
from
973276b
to
3c8e589
Compare
stringhandler
approved these changes
Aug 15, 2023
Cifko
approved these changes
Aug 15, 2023
Cifko
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
cool, the new error message Fee transaction rejected: Shard was rejected: Validators decided to abort: Execution failure: Runtime error: Resource did not contain sufficient balance: Bucket contained insufficient revealed funds. Required: 1500, Available: 100 this will be super useful when testing
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Aug 16, 2023
* development: fix!: peer sync (tari-project#657) fix(vn/ui): committee bucket information (tari-project#656) fix(engine): return engine error from instruction invocation (tari-project#655) fix(walletd): fix race condition causing transaction to be marked as invalid (tari-project#654) ci: double test timeout fix(vn-webui): fix incorrect jsonrpc address (tari-project#645) fix: add feeclaim_xxx address parsing (tari-project#648)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(engine): return engine error from instruction invocation
fix: only unlock on abort if inputs were originally locked
fix(wallet): propagate result error from vn to wallet cli
fix(wallet/cli): enable amounts bigger than u32::MAX to be input as an arg
Motivation and Context
Hook up errors returned by the runtime to the final transaction result. This takes precedence over a panic (which MUST always occur after an engine error).
Hook up the result properly so that it is returned even when the transaction is aborted. This allows the client to get the actual error that occurred during execution.
How Has This Been Tested?
New engine unit test that performs an invalid engine call, the WASM panics and we check that the result includes the underlying engine error rather than the null ptr panic error.
Manually, send more funds than available.
What process can a PR reviewer use to test or verify this change?
Create a wallet and send more funds than available, the error is now output rather than a unknown error or WASM panic text
Breaking Changes