-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix out res #198
Fix out res #198
Conversation
Simplifies the way OUTRIDER results are saved and the link to download them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I trust that it works. Some minor comments on defining output file paths. It's good to have all outputs in the Snakemake header, so that they can be handled by Snakemake
Major changes included in this update is: * adapt to new snakemake version (#208) * Speedup CI (use micromamba, #218) * Add HTML cutoff for results (#217) * Separate modules (#209) * Update documentation (#228) On top of this many small bug-fixes are included: * #175 #192 #198 #231 * Simplify result reporting Co-authored-by: Vicente Yepez <30469316+vyepez88@users.noreply.github.com> Co-authored-by: Vicente <yepez@in.tum.de> Co-authored-by: Michaela Mueller <51025211+mumichae@users.noreply.github.com> Co-authored-by: Michaela Mueller <mumichae@in.tum.de> Co-authored-by: Smith Nicholas <smith@in.tum.de> Co-authored-by: nickhsmith <smithnickh@gmail.com> Co-authored-by: Christian Mertes <mertes@in.tum.de>
* Update to version 1.1.0 (#229) Major changes included in this update is: * adapt to new snakemake version (#208) * Speedup CI (use micromamba, #218) * Add HTML cutoff for results (#217) * Separate modules (#209) * Update documentation (#228) On top of this many small bug-fixes are included: * #175 #192 #198 #231 * Simplify result reporting Co-authored-by: Vicente Yepez <30469316+vyepez88@users.noreply.github.com> Co-authored-by: Vicente <yepez@in.tum.de> Co-authored-by: Michaela Mueller <51025211+mumichae@users.noreply.github.com> Co-authored-by: Michaela Mueller <mumichae@in.tum.de> Co-authored-by: Smith Nicholas <smith@in.tum.de> Co-authored-by: nickhsmith <smithnickh@gmail.com> Co-authored-by: Christian Mertes <mertes@in.tum.de> * add splitting to MAE filterSNVs.sh * fix broken link and maxVarFreqCohort * fix broken link and maxVarFreqCohort * Update test_MAE.py * code review fixes Co-authored-by: Michaela Mueller <51025211+mumichae@users.noreply.github.com> Co-authored-by: Vicente Yepez <30469316+vyepez88@users.noreply.github.com> Co-authored-by: Vicente <yepez@in.tum.de> Co-authored-by: Michaela Mueller <mumichae@in.tum.de> Co-authored-by: Smith Nicholas <smith@in.tum.de> Co-authored-by: Christian Mertes <mertes@in.tum.de>
No description provided.