Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html table cutoff #217

Merged
merged 12 commits into from
Jun 30, 2021
Merged

Html table cutoff #217

merged 12 commits into from
Jun 30, 2021

Conversation

nickhsmith
Copy link
Collaborator

make a hard cutoff for the html table summary for each module

@nickhsmith nickhsmith changed the base branch from master to dev June 24, 2021 19:00
@mumichae mumichae self-requested a review June 25, 2021 08:13
@nickhsmith nickhsmith requested a review from vyepez88 June 25, 2021 19:14

DT::datatable(
head(res, 1000),
caption = 'Taking a look at no more than the first 1,000 OUTRIDER results.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the caption to: OUTRIDER results (up to 1,000 rows shown)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also in the other 2 cases

Copy link
Collaborator Author

@nickhsmith nickhsmith Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in recent push (commit c8f4de2)

@mumichae mumichae merged commit dca30d8 into dev Jun 30, 2021
@mumichae mumichae deleted the html_table_cutoff branch July 15, 2021 14:26
@mumichae mumichae mentioned this pull request Jul 15, 2021
c-mertes added a commit that referenced this pull request Jul 21, 2021
Major changes included in this update is:
* adapt to new snakemake version (#208)
* Speedup CI (use micromamba, #218)
* Add HTML cutoff for results (#217)
* Separate modules (#209)
* Update documentation (#228)

On top of this many small bug-fixes are included:
* #175 #192 #198 #231
* Simplify result reporting


Co-authored-by: Vicente Yepez <30469316+vyepez88@users.noreply.github.com>
Co-authored-by: Vicente <yepez@in.tum.de>
Co-authored-by: Michaela Mueller <51025211+mumichae@users.noreply.github.com>
Co-authored-by: Michaela Mueller <mumichae@in.tum.de>
Co-authored-by: Smith Nicholas <smith@in.tum.de>
Co-authored-by: nickhsmith <smithnickh@gmail.com>
Co-authored-by: Christian Mertes <mertes@in.tum.de>
nickhsmith added a commit that referenced this pull request Aug 11, 2021
* Update to version 1.1.0 (#229)

Major changes included in this update is:
* adapt to new snakemake version (#208)
* Speedup CI (use micromamba, #218)
* Add HTML cutoff for results (#217)
* Separate modules (#209)
* Update documentation (#228)

On top of this many small bug-fixes are included:
* #175 #192 #198 #231
* Simplify result reporting


Co-authored-by: Vicente Yepez <30469316+vyepez88@users.noreply.github.com>
Co-authored-by: Vicente <yepez@in.tum.de>
Co-authored-by: Michaela Mueller <51025211+mumichae@users.noreply.github.com>
Co-authored-by: Michaela Mueller <mumichae@in.tum.de>
Co-authored-by: Smith Nicholas <smith@in.tum.de>
Co-authored-by: nickhsmith <smithnickh@gmail.com>
Co-authored-by: Christian Mertes <mertes@in.tum.de>

* add splitting to MAE filterSNVs.sh

* fix broken link and maxVarFreqCohort

* fix broken link and maxVarFreqCohort

* Update test_MAE.py

* code review fixes

Co-authored-by: Michaela Mueller <51025211+mumichae@users.noreply.github.com>
Co-authored-by: Vicente Yepez <30469316+vyepez88@users.noreply.github.com>
Co-authored-by: Vicente <yepez@in.tum.de>
Co-authored-by: Michaela Mueller <mumichae@in.tum.de>
Co-authored-by: Smith Nicholas <smith@in.tum.de>
Co-authored-by: Christian Mertes <mertes@in.tum.de>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants