-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate modules #209
Merged
Merged
Separate modules #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dDataDir/preprocess
mumichae
reviewed
Jun 16, 2021
mumichae
reviewed
Jun 16, 2021
mumichae
reviewed
Jun 16, 2021
mumichae
reviewed
Jun 16, 2021
mumichae
reviewed
Jun 16, 2021
mumichae
reviewed
Jun 16, 2021
mumichae
reviewed
Jun 16, 2021
mumichae
reviewed
Jun 16, 2021
…into separate_modules
nickhsmith
commented
Jun 30, 2021
drop/template/Snakefile
Outdated
include: drop.utils.getWBuildSnakefile() | ||
include: cfg.AE.getWorkdir() + "/Snakefile" | ||
include: cfg.AS.getWorkdir() + "/Snakefile" | ||
include: cfg.MAE.getWorkdir() + "/Snakefile" | ||
|
||
|
||
# don't allow the dataset wildcard to contain '--' as this is a delimter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delimiter
vyepez88
approved these changes
Jun 30, 2021
Merged
c-mertes
added a commit
that referenced
this pull request
Jul 21, 2021
Major changes included in this update is: * adapt to new snakemake version (#208) * Speedup CI (use micromamba, #218) * Add HTML cutoff for results (#217) * Separate modules (#209) * Update documentation (#228) On top of this many small bug-fixes are included: * #175 #192 #198 #231 * Simplify result reporting Co-authored-by: Vicente Yepez <30469316+vyepez88@users.noreply.github.com> Co-authored-by: Vicente <yepez@in.tum.de> Co-authored-by: Michaela Mueller <51025211+mumichae@users.noreply.github.com> Co-authored-by: Michaela Mueller <mumichae@in.tum.de> Co-authored-by: Smith Nicholas <smith@in.tum.de> Co-authored-by: nickhsmith <smithnickh@gmail.com> Co-authored-by: Christian Mertes <mertes@in.tum.de>
nickhsmith
added a commit
that referenced
this pull request
Aug 11, 2021
* Update to version 1.1.0 (#229) Major changes included in this update is: * adapt to new snakemake version (#208) * Speedup CI (use micromamba, #218) * Add HTML cutoff for results (#217) * Separate modules (#209) * Update documentation (#228) On top of this many small bug-fixes are included: * #175 #192 #198 #231 * Simplify result reporting Co-authored-by: Vicente Yepez <30469316+vyepez88@users.noreply.github.com> Co-authored-by: Vicente <yepez@in.tum.de> Co-authored-by: Michaela Mueller <51025211+mumichae@users.noreply.github.com> Co-authored-by: Michaela Mueller <mumichae@in.tum.de> Co-authored-by: Smith Nicholas <smith@in.tum.de> Co-authored-by: nickhsmith <smithnickh@gmail.com> Co-authored-by: Christian Mertes <mertes@in.tum.de> * add splitting to MAE filterSNVs.sh * fix broken link and maxVarFreqCohort * fix broken link and maxVarFreqCohort * Update test_MAE.py * code review fixes Co-authored-by: Michaela Mueller <51025211+mumichae@users.noreply.github.com> Co-authored-by: Vicente Yepez <30469316+vyepez88@users.noreply.github.com> Co-authored-by: Vicente <yepez@in.tum.de> Co-authored-by: Michaela Mueller <mumichae@in.tum.de> Co-authored-by: Smith Nicholas <smith@in.tum.de> Co-authored-by: Christian Mertes <mertes@in.tum.de>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate modules using config file options.
update submodule to have workDir attributes
update cli to correctly update drop from base dir
update Snakefile handling and shared input/output generation
method to ignore modules in wBuild by changing the filename to an ignorable path