Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate modules #209

Merged
merged 39 commits into from
Jun 30, 2021
Merged

Separate modules #209

merged 39 commits into from
Jun 30, 2021

Conversation

nickhsmith
Copy link
Collaborator

Separate modules using config file options.

update submodule to have workDir attributes
update cli to correctly update drop from base dir
update Snakefile handling and shared input/output generation
method to ignore modules in wBuild by changing the filename to an ignorable path

drop/template/Snakefile Outdated Show resolved Hide resolved
drop/template/Snakefile Outdated Show resolved Hide resolved
drop/template/Snakefile Outdated Show resolved Hide resolved
drop/template/config.yaml Outdated Show resolved Hide resolved
tests/common.py Outdated Show resolved Hide resolved
@mumichae mumichae marked this pull request as ready for review June 21, 2021 21:17
include: drop.utils.getWBuildSnakefile()
include: cfg.AE.getWorkdir() + "/Snakefile"
include: cfg.AS.getWorkdir() + "/Snakefile"
include: cfg.MAE.getWorkdir() + "/Snakefile"


# don't allow the dataset wildcard to contain '--' as this is a delimter
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delimiter

@nickhsmith nickhsmith merged commit c885d8e into dev Jun 30, 2021
@nickhsmith nickhsmith deleted the separate_modules branch June 30, 2021 20:42
@mumichae mumichae mentioned this pull request Jul 15, 2021
c-mertes added a commit that referenced this pull request Jul 21, 2021
Major changes included in this update is:
* adapt to new snakemake version (#208)
* Speedup CI (use micromamba, #218)
* Add HTML cutoff for results (#217)
* Separate modules (#209)
* Update documentation (#228)

On top of this many small bug-fixes are included:
* #175 #192 #198 #231
* Simplify result reporting


Co-authored-by: Vicente Yepez <30469316+vyepez88@users.noreply.github.com>
Co-authored-by: Vicente <yepez@in.tum.de>
Co-authored-by: Michaela Mueller <51025211+mumichae@users.noreply.github.com>
Co-authored-by: Michaela Mueller <mumichae@in.tum.de>
Co-authored-by: Smith Nicholas <smith@in.tum.de>
Co-authored-by: nickhsmith <smithnickh@gmail.com>
Co-authored-by: Christian Mertes <mertes@in.tum.de>
nickhsmith added a commit that referenced this pull request Aug 11, 2021
* Update to version 1.1.0 (#229)

Major changes included in this update is:
* adapt to new snakemake version (#208)
* Speedup CI (use micromamba, #218)
* Add HTML cutoff for results (#217)
* Separate modules (#209)
* Update documentation (#228)

On top of this many small bug-fixes are included:
* #175 #192 #198 #231
* Simplify result reporting


Co-authored-by: Vicente Yepez <30469316+vyepez88@users.noreply.github.com>
Co-authored-by: Vicente <yepez@in.tum.de>
Co-authored-by: Michaela Mueller <51025211+mumichae@users.noreply.github.com>
Co-authored-by: Michaela Mueller <mumichae@in.tum.de>
Co-authored-by: Smith Nicholas <smith@in.tum.de>
Co-authored-by: nickhsmith <smithnickh@gmail.com>
Co-authored-by: Christian Mertes <mertes@in.tum.de>

* add splitting to MAE filterSNVs.sh

* fix broken link and maxVarFreqCohort

* fix broken link and maxVarFreqCohort

* Update test_MAE.py

* code review fixes

Co-authored-by: Michaela Mueller <51025211+mumichae@users.noreply.github.com>
Co-authored-by: Vicente Yepez <30469316+vyepez88@users.noreply.github.com>
Co-authored-by: Vicente <yepez@in.tum.de>
Co-authored-by: Michaela Mueller <mumichae@in.tum.de>
Co-authored-by: Smith Nicholas <smith@in.tum.de>
Co-authored-by: Christian Mertes <mertes@in.tum.de>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants