[config] remove unused EvmNetworkID(),SetEVMNetworkID() #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3503 +/- ##
==========================================
- Coverage 75.35% 75.34% -0.01%
==========================================
Files 246 246
Lines 22754 22748 -6
==========================================
- Hits 17146 17140 -6
Misses 4683 4683
Partials 925 925
Continue to review full report at Codecov.
|
Liuhaai
reviewed
Jul 6, 2022
config/config.go
Outdated
| @@ -35,8 +34,7 @@ import ( | |||
| // the default value in Default var. | |||
|
|
|||
| var ( | |||
| _evmNetworkID uint32 | |||
| _loadChainID sync.Once | |||
| _loadChainID sync.Once | |||
Liuhaai
approved these changes
Jul 6, 2022
dustinxie
reviewed
Jul 6, 2022
| @@ -108,18 +108,12 @@ func main() { | |||
| } | |||
| defer recovery.Recover() | |||
|
|
|||
| // populdate chain ID | |||
| config.SetEVMNetworkID(cfg.Chain.EVMNetworkID) | |||
| if config.EVMNetworkID() == 0 { | |||
There was a problem hiding this comment.
keep this check
if cfg.Chain.EVMNetworkID == 0
dustinxie
reviewed
Jul 6, 2022
| cfg.Genesis = genesisCfg | ||
| cfgToLog := cfg | ||
| cfgToLog.Chain.ProducerPrivKey = "" | ||
| cfgToLog.Network.MasterKey = "" | ||
| log.S().Infof("Config in use: %+v", cfgToLog) | ||
| log.S().Infof("EVM Network ID: %d, Chain ID: %d", config.EVMNetworkID(), cfg.Chain.ID) |
There was a problem hiding this comment.
keep this printout, the value is cfg.Chain.EVMNetworkID
dustinxie
approved these changes
Jul 6, 2022
pocockn
added a commit
to pocockn/iotex-core
that referenced
this pull request
Jul 19, 2022
* upstream/master: (28 commits) [ioctl] Incorrect conversion between integer types (iotexproject#3522) [action] fix incorrect conversion between integer types (iotexproject#3545) [test] fix TestLoadBlockchainfromDB (iotexproject#3521) [ioctl] correct Chinese usage message (iotexproject#3510) fix err not hanled (iotexproject#3509) add ReadHeaderTimeout (iotexproject#3539) [iotcl] Reset config cmd (iotexproject#3496) Update gosec.yaml Update ci.yaml Update analysis.yaml Delete gosec.yaml.bak Create gosec.yaml [config] move config.ActPool to actpool package refactor (iotexproject#3514) Update ci.yaml Update analysis.yaml Update analysis.yaml [config] move config.Chain to blockchain package (iotexproject#3511) remove circleci (iotexproject#3498) [ioctl] Build block bucketlist command line into new ioctl (iotexproject#3469) [config] remove EVMNetworkID() and SetEVMNetworkID() (iotexproject#3503) ...
dustinxie
added a commit
that referenced
this pull request
Oct 5, 2022
Co-authored-by: dustinxie <dahuaxie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove unsed config funcs
EvmNetworkID()SetEVMNetworkID()Fixes #3502
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: