[ioctl] correct Chinese usage message #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3510 +/- ##
==========================================
- Coverage 75.43% 74.52% -0.92%
==========================================
Files 247 252 +5
Lines 22845 23115 +270
==========================================
- Hits 17233 17226 -7
- Misses 4685 4964 +279
+ Partials 927 925 -2
Continue to review full report at Codecov.
|
Liuhaai
approved these changes
Jul 7, 2022
CoderZhi
reviewed
Jul 11, 2022
|
fix all ioctl command usage message. if is command itself, use English directly. |
CoderZhi
approved these changes
Jul 12, 2022
| short, _ := client.SelectTranslation(_hdwalletExportCmdShorts) | ||
|
|
||
| return &cobra.Command{ | ||
| Use: use, | ||
| Use: "export", |
| short, _ := client.SelectTranslation(_importCmdShorts) | ||
|
|
||
| return &cobra.Command{ | ||
| Use: use, | ||
| Use: "import", |
pocockn
added a commit
to pocockn/iotex-core
that referenced
this pull request
Jul 19, 2022
* upstream/master: (28 commits) [ioctl] Incorrect conversion between integer types (iotexproject#3522) [action] fix incorrect conversion between integer types (iotexproject#3545) [test] fix TestLoadBlockchainfromDB (iotexproject#3521) [ioctl] correct Chinese usage message (iotexproject#3510) fix err not hanled (iotexproject#3509) add ReadHeaderTimeout (iotexproject#3539) [iotcl] Reset config cmd (iotexproject#3496) Update gosec.yaml Update ci.yaml Update analysis.yaml Delete gosec.yaml.bak Create gosec.yaml [config] move config.ActPool to actpool package refactor (iotexproject#3514) Update ci.yaml Update analysis.yaml Update analysis.yaml [config] move config.Chain to blockchain package (iotexproject#3511) remove circleci (iotexproject#3498) [ioctl] Build block bucketlist command line into new ioctl (iotexproject#3469) [config] remove EVMNetworkID() and SetEVMNetworkID() (iotexproject#3503) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
command in Chinese should be English. otherwise, error occurs.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: