[config] move config.ActPool to actpool package refactor #3514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinxie
reviewed
Jul 11, 2022
| require.NoError(t, err) | ||
| pp, err := poll.NewGovernanceChainCommitteeProtocol( | ||
| nil, | ||
| committee, | ||
| uint64(123456), | ||
| func(uint64) (time.Time, error) { return time.Now(), nil }, | ||
| cfg.Chain.PollInitialCandidatesInterval, | ||
| bcf.PollInitialCandidatesInterval, |
There was a problem hiding this comment.
directly use blockchain.DefaultConfig.PollInitialCandidatesInterval here, no need to define bcf
dustinxie
reviewed
Jul 11, 2022
config/config_test.go
Outdated
| @@ -312,7 +313,7 @@ func TestValidateActPool(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestValidateMinGasPrice(t *testing.T) { | |||
| ap := ActPool{MinGasPriceStr: Default.ActPool.MinGasPriceStr} | |||
| ap := actpool.Config{MinGasPriceStr: Default.ActPool.MinGasPriceStr} | |||
There was a problem hiding this comment.
move this test to actpool package
dustinxie
reviewed
Jul 11, 2022
action/protocol/poll/protocol.go
Outdated
| "github.com/iotexproject/iotex-core/pkg/log" | ||
| "github.com/iotexproject/iotex-core/state" | ||
| ) | ||
|
|
||
| const ( | ||
| _protocolID = "poll" | ||
| // RollDPoSScheme means randomized delegated proof of stake | ||
| RollDPoSScheme = "ROLLDPOS" |
There was a problem hiding this comment.
_rollDPoSScheme no need to export
dustinxie
approved these changes
Jul 11, 2022
Liuhaai
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3514 +/- ##
==========================================
- Coverage 75.43% 74.54% -0.89%
==========================================
Files 247 251 +4
Lines 22845 23117 +272
==========================================
Hits 17233 17233
- Misses 4685 4957 +272
Partials 927 927
Continue to review full report at Codecov.
|
|
The changes on |
If no change here, will get an "import cycle not allowed" error on build |
Liuhaai
approved these changes
Jul 12, 2022
pocockn
added a commit
to pocockn/iotex-core
that referenced
this pull request
Jul 19, 2022
* upstream/master: (28 commits) [ioctl] Incorrect conversion between integer types (iotexproject#3522) [action] fix incorrect conversion between integer types (iotexproject#3545) [test] fix TestLoadBlockchainfromDB (iotexproject#3521) [ioctl] correct Chinese usage message (iotexproject#3510) fix err not hanled (iotexproject#3509) add ReadHeaderTimeout (iotexproject#3539) [iotcl] Reset config cmd (iotexproject#3496) Update gosec.yaml Update ci.yaml Update analysis.yaml Delete gosec.yaml.bak Create gosec.yaml [config] move config.ActPool to actpool package refactor (iotexproject#3514) Update ci.yaml Update analysis.yaml Update analysis.yaml [config] move config.Chain to blockchain package (iotexproject#3511) remove circleci (iotexproject#3498) [ioctl] Build block bucketlist command line into new ioctl (iotexproject#3469) [config] remove EVMNetworkID() and SetEVMNetworkID() (iotexproject#3503) ...
dustinxie
pushed a commit
that referenced
this pull request
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #3513
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: