Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Add ReadHeaderTimeout #3539

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

Liuhaai
Copy link
Member

@Liuhaai Liuhaai commented Jul 12, 2022

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3538

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@Liuhaai Liuhaai requested a review from a team as a code owner July 12, 2022 21:01
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #3539 (b080485) into master (a20e489) will decrease coverage by 0.84%.
The diff coverage is 61.62%.

❗ Current head b080485 differs from pull request most recent head 57788a9. Consider uploading reports for the commit 57788a9 to get more accurate results

@@            Coverage Diff             @@
##           master    #3539      +/-   ##
==========================================
- Coverage   75.43%   74.59%   -0.85%     
==========================================
  Files         247      252       +5     
  Lines       22845    23134     +289     
==========================================
+ Hits        17233    17256      +23     
- Misses       4685     4951     +266     
  Partials      927      927              
Impacted Files Coverage Δ
blockchain/blockchain.go 0.89% <0.00%> (ø)
config/config.go 94.06% <ø> (+9.31%) ⬆️
actpool/config.go 60.00% <60.00%> (ø)
blockchain/config.go 65.78% <65.78%> (ø)
action/protocol/poll/protocol.go 68.13% <66.66%> (-0.35%) ⬇️
actpool/actpool.go 87.09% <100.00%> (ø)
api/http.go 88.88% <100.00%> (+0.31%) ⬆️
blockchain/filedao/testing.go 59.71% <100.00%> (ø)
ioctl/client.go 73.61% <100.00%> (+0.32%) ⬆️
ioctl/newcmd/config/config_reset.go 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58b89f7...57788a9. Read the comment docs.

@dustinxie dustinxie merged commit 0d72eb7 into iotexproject:master Jul 12, 2022
pocockn added a commit to pocockn/iotex-core that referenced this pull request Jul 19, 2022
* upstream/master: (28 commits)
  [ioctl] Incorrect conversion between integer types (iotexproject#3522)
  [action] fix incorrect conversion between integer types (iotexproject#3545)
  [test] fix TestLoadBlockchainfromDB (iotexproject#3521)
  [ioctl] correct Chinese usage message (iotexproject#3510)
  fix err not hanled (iotexproject#3509)
  add ReadHeaderTimeout (iotexproject#3539)
  [iotcl] Reset config cmd (iotexproject#3496)
  Update gosec.yaml
  Update ci.yaml
  Update analysis.yaml
  Delete gosec.yaml.bak
  Create gosec.yaml
  [config] move config.ActPool to actpool package refactor (iotexproject#3514)
  Update ci.yaml
  Update analysis.yaml
  Update analysis.yaml
  [config] move config.Chain to blockchain package (iotexproject#3511)
  remove circleci (iotexproject#3498)
  [ioctl] Build block bucketlist command line into new ioctl (iotexproject#3469)
  [config] remove  EVMNetworkID() and SetEVMNetworkID() (iotexproject#3503)
  ...
dustinxie pushed a commit that referenced this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server
3 participants