Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fab] Migrate to emotion #24569

Closed
wants to merge 39 commits into from
Closed

[Fab] Migrate to emotion #24569

wants to merge 39 commits into from

Conversation

natac13
Copy link
Contributor

@natac13 natac13 commented Jan 23, 2021

Sorry I have still not completely figured out how to do this. I think I am mostly there.
#24405

Thank you for the help with #24567

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 23, 2021

@material-ui/core: parsed: +0.17% , gzip: +0.13%
@material-ui/lab: parsed: +0.16% , gzip: +0.26%

Details of bundle changes

Generated by 🚫 dangerJS against 685d085

@oliviertassinari oliviertassinari changed the title [Fab]: Migrate to Emotion [Fab] Migrate to Emotion Jan 23, 2021
@oliviertassinari oliviertassinari added the component: Fab The React component. label Jan 23, 2021
@oliviertassinari oliviertassinari changed the title [Fab] Migrate to Emotion [Fab] Migrate to emotion Jan 23, 2021
@natac13
Copy link
Contributor Author

natac13 commented Jan 25, 2021

I still get 1 test failing. However it is the SpeedDial component.

@mnajdova
Copy link
Member

@natac13 can you please rebase to next, I see too many unrelated changes. Thanks!

@natac13
Copy link
Contributor Author

natac13 commented Jan 25, 2021

I am not sure how. 😞 Let me close and open new PR 👍🏻

@natac13 natac13 closed this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Fab The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.