feat(miner): add SHA P2Pool mining related configuration and changes #6370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
reviewed
Jun 25, 2024
| async fn submit_block( | ||
| config: &MinerConfig, | ||
| base_node_client: &mut BaseNodeGrpcClient, | ||
| sha_p2pool_client: Arc<Mutex<Option<ShaP2PoolGrpcClient>>>, |
There was a problem hiding this comment.
I suspect you don't need a mutex.
Suggested change
| sha_p2pool_client: Arc<Mutex<Option<ShaP2PoolGrpcClient>>>, | |
| sha_p2pool_client: Option<&mut ShaP2PoolGrpcClient>, |
Call with:
submit_block(base_node_client, sha_p2pool_client.as_mut(), ....)There was a problem hiding this comment.
okay makes sense, just pushed
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 120 suites 35m 30s ⏱️ Results for commit 982c89a. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files + 2 11 suites +11 42m 48s ⏱️ + 42m 48s For more details on these failures, see this check. Results for commit 982c89a. ± Comparison against base commit 43b76d9. ♻️ This comment has been updated with latest results. |
sdbondi
changed the title
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jul 22, 2024
* development: (93 commits) chore: fix build and osp (tari-project#6415) chore: refactor key manager names (tari-project#6411) fix: panic in from_base58 fn (tari-project#6414) fix: branch keys (tari-project#6413) chore: remove dependancy on ledger for common types (tari-project#6412) feat: count unique keys (tari-project#6401) feat!: fix key manager use of keys (tari-project#6407) refactor: remove metadata sig and use difference key branch for offset (tari-project#6400) feat: update ledger instructions (tari-project#6406) feat: add file-based input and output to faucet commands (tari-project#6405) chore: new release v1.0.0-pre.16 (tari-project#6404) feat: simplify leader sig generation (tari-project#6399) ci(fix): include macOS universal assets in release (tari-project#6402) fix: script dependance on party order (tari-project#6398) fix: claim n of m faucet (tari-project#6389) feat: add ffi features (tari-project#6390) chore: fix unwraps in memory key manager (tari-project#6396) docs: update hasher documentation (tari-project#6392) chore: fix ci (tari-project#6391) feat(miner): add SHA P2Pool mining related configuration and changes (tari-project#6370) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a new decentralized P2Pool implementation in progress for SHA3 based mining on Tari.
To be able to connect and use this new implementation we need to have some new changes introduced in this PR.
Overall to make the usage of the new mining pool as easy as possible, I introduced a new configuration in the miner called
sha_p2pool_enabledand if it's set to true andbase_node_grpc_addressconfig is set to the address of thep2pool nodethen the mining starts on the decentralized pool.Motivation and Context
How Has This Been Tested?
What process can a PR reviewer use to test or verify this change?
Breaking Changes