Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: script dependance on party order #6398

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

fixes script dependence on party order

Motivation and Context

Currently, the m-of-n ceremony is dependant on the leader selection to succeed or not. This fixes the process so that the leader correctly constructs the input stack for the script in the correct order.

How Has This Been Tested?

manual

@SWvheerden SWvheerden requested a review from a team as a code owner July 11, 2024 13:44
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

Test Results (CI)

    3 files    120 suites   42m 42s ⏱️
1 295 tests 1 295 ✅ 0 💤 0 ❌
3 877 runs  3 877 ✅ 0 💤 0 ❌

Results for commit c9cd54c.

@ghpbot-tari-project ghpbot-tari-project added the P-acks_required Process - Requires more ACKs or utACKs label Jul 11, 2024
Copy link

Test Results (Integration tests)

 2 files  11 suites   34m 24s ⏱️
35 tests 33 ✅ 0 💤 2 ❌
38 runs  35 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit c9cd54c.

@SWvheerden SWvheerden merged commit 2b22c1a into tari-project:development Jul 11, 2024
14 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_fix_script branch July 12, 2024 12:43
sdbondi added a commit to sdbondi/tari that referenced this pull request Jul 22, 2024
* development: (93 commits)
  chore: fix build and osp (tari-project#6415)
  chore: refactor key manager names (tari-project#6411)
  fix: panic in from_base58 fn (tari-project#6414)
  fix: branch keys (tari-project#6413)
  chore: remove dependancy on ledger for common types (tari-project#6412)
  feat: count unique keys (tari-project#6401)
  feat!: fix key manager use of keys (tari-project#6407)
  refactor: remove metadata sig and use difference key branch for offset (tari-project#6400)
  feat: update ledger instructions (tari-project#6406)
  feat: add file-based input and output to faucet commands (tari-project#6405)
  chore: new release v1.0.0-pre.16 (tari-project#6404)
  feat: simplify leader sig generation (tari-project#6399)
  ci(fix): include macOS universal assets in release (tari-project#6402)
  fix: script dependance on party order (tari-project#6398)
  fix: claim n of m faucet (tari-project#6389)
  feat: add ffi features (tari-project#6390)
  chore: fix unwraps in memory key manager (tari-project#6396)
  docs: update hasher documentation (tari-project#6392)
  chore: fix ci (tari-project#6391)
  feat(miner): add SHA P2Pool mining related configuration and changes (tari-project#6370)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants