chore: refactor key manager names #6411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 36m 37s ⏱️ Results for commit 5a6a2d9. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 16m 53s ⏱️ + 16m 53s For more details on these failures, see this check. Results for commit 5a6a2d9. ± Comparison against base commit 35db898. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Happy with the most part, except:
spend_keyorspending_keyshould be changed withcommitment_mask, not withcommitment_mask_keyorcommitment_mask_key_id- If something is of type
KeyAndId, we should be careful to not repeat ourselves in the name, but sometime it is fine likeview_keyand 'spend_key`.
Co-authored-by: Hansie Odendaal <39146854+hansieodendaal@users.noreply.github.com>
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jul 22, 2024
* development: (93 commits) chore: fix build and osp (tari-project#6415) chore: refactor key manager names (tari-project#6411) fix: panic in from_base58 fn (tari-project#6414) fix: branch keys (tari-project#6413) chore: remove dependancy on ledger for common types (tari-project#6412) feat: count unique keys (tari-project#6401) feat!: fix key manager use of keys (tari-project#6407) refactor: remove metadata sig and use difference key branch for offset (tari-project#6400) feat: update ledger instructions (tari-project#6406) feat: add file-based input and output to faucet commands (tari-project#6405) chore: new release v1.0.0-pre.16 (tari-project#6404) feat: simplify leader sig generation (tari-project#6399) ci(fix): include macOS universal assets in release (tari-project#6402) fix: script dependance on party order (tari-project#6398) fix: claim n of m faucet (tari-project#6389) feat: add ffi features (tari-project#6390) chore: fix unwraps in memory key manager (tari-project#6396) docs: update hasher documentation (tari-project#6392) chore: fix ci (tari-project#6391) feat(miner): add SHA P2Pool mining related configuration and changes (tari-project#6370) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactors the key manger names to ensure they are easier to read
Motivation and Context
the names are not correct and all over the place. This changes the names to make it easier to read the code.
How Has This Been Tested?
unit test