Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in Group Edit after enabling Browser Integration #8778

Merged

Conversation

varjolintu
Copy link
Member

If Browser Integration is disabled when KeePassXC is started, and then enabled, Group Edit crashes because the Browser Integration group page is not created. Currently it is only done in the class constructor.
It needs to be created only once, thus the check for nullptr instead of hasPage().

Also hides the page from Group Edit if Browser Integration is disabled. The page shouldn't be no longer visible.

Fixes #8775.

Testing strategy

Manually.

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@codecov-commenter
Copy link

Codecov Report

Base: 64.43% // Head: 64.40% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (6be76b9) compared to base (3cbe4df).
Patch coverage: 75.76% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8778      +/-   ##
===========================================
- Coverage    64.43%   64.40%   -0.02%     
===========================================
  Files          341      341              
  Lines        44247    44256       +9     
===========================================
- Hits         28507    28503       -4     
- Misses       15740    15753      +13     
Impacted Files Coverage Δ
src/gui/group/EditGroupWidget.h 100.00% <ø> (ø)
src/gui/group/EditGroupWidget.cpp 66.56% <75.76%> (-1.67%) ⬇️
src/core/Tools.cpp 73.40% <0.00%> (-0.64%) ⬇️
src/gui/osutils/nixutils/NixUtils.cpp 34.95% <0.00%> (-0.54%) ⬇️
src/core/Entry.cpp 82.52% <0.00%> (-0.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@droidmonkey droidmonkey merged commit ad773c5 into keepassxreboot:develop Dec 19, 2022
pull bot pushed a commit to tigerwill90/keepassxc that referenced this pull request Dec 19, 2022
@varjolintu varjolintu deleted the fix/crash_in_group_edit branch December 19, 2022 13:36
Perlover added a commit to Perlover/keepassxc that referenced this pull request May 18, 2023
Release 2.7.5

- Add menu option to allow screenshots [keepassxreboot#8841]
- Add support for Botan 3 [keepassxreboot#9388]
- Increase max TOTP step to 24 hours [keepassxreboot#9149]
- Improve HTML export layout [keepassxreboot#8987]
- Turn search reset off by default [keepassxreboot#9153]
- Use QClipboard::clear() instead of setting blank text [keepassxreboot#9148]
- Hide group column header choice when not in search [keepassxreboot#9171]
- Improve look of KeePassXC logo and icons [keepassxreboot#9355]
- Add keyboard shortcuts for app and database settings [keepassxreboot#9007]
- Hide rename button from attachments preview panel [keepassxreboot#8842]
- Linux: Set SingleMainWindow in .desktop file [keepassxreboot#7430]

- Fix crash when search clears while creating new entry [keepassxreboot#9230]
- Fix crash when using Windows Hello in a Remote Desktop session [keepassxreboot#9006]
- Fix crash in Group Edit after enabling Browser Integration [keepassxreboot#8778]
- Fix canceling quick unlock when it is unavailable [keepassxreboot#9034]
- Set password input field font correctly [keepassxreboot#8732]
- Greatly improve performance when rendering entry view [keepassxreboot#9398]
- Fix various accessibility issues [keepassxreboot#9138]
- Fix arrows size when expand/collapse a group [keepassxreboot#9096]
- Select the clone instead of the original after cloning an entry [keepassxreboot#9070]
- Fix bugs with preview widget [keepassxreboot#9170]
- Fix status bar update when switching to other DB [keepassxreboot#9073]
- Fix database settings spin box bug [keepassxreboot#9101]
- Fix Ctrl+Tab shortcut to cycle databases in unlock dialog [keepassxreboot#8839]
- Fix TOTP QR code maintaining square ratio [keepassxreboot#9027]
- Fix Auto-Type configuration page on custom sequence selection [keepassxreboot#8752]
- Fix unexpected behavior of `--lock` when KeePassXC is not running [keepassxreboot#8889]
- Make open folder icon exempt from "Apply group icon to entry" [keepassxreboot#9205]
- Allow setting default file open directory with env var [keepassxreboot#9192]
- SSH Agent: Fix support for AES-256/GCM openssh keys [keepassxreboot#8968]
- Browser: Fix Native Messaging script path with BSD OS's [keepassxreboot#8835]
- MacOS: Fix text selection for Auto-Type clear field [keepassxreboot#9066]
- MacOS: Don't rely on AppleInterfaceStyle for theme switching [keepassxreboot#8615]
- Windows: Remove registry detection of desktop shortcut [keepassxreboot#9380]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when editing group after enabling browser integration
3 participants