Fix status bar update when switching to other DB #9073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will add GUI test later. |
Codecov ReportBase: 64.83% // Head: 64.85% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #9073 +/- ##
===========================================
+ Coverage 64.83% 64.85% +0.02%
===========================================
Files 342 342
Lines 44392 44393 +1
===========================================
+ Hits 28781 28789 +8
+ Misses 15611 15604 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
droidmonkey
approved these changes
Feb 6, 2023
[What]
1) Defined the object name for the StatusBarLabel.
2) Implemented a separate method to find the StatusBarLabel, check the
visibility and compare the actual text with given expected one.
3) Added the validation of the StatusBarLabel in some tests where the
entries are adding or deleting.
[Why]
This is a part of the StatusBarLabel bug fixing.
The StatusBarLabel was not verified in GUI tests.
[What] Added verification of the StatusBarLabel after new DB creation and on DB tab switching. [Why] This is a part of the StatusBarLabel bug fixing.
pull bot
pushed a commit
to tigerwill90/keepassxc
that referenced
this pull request
Feb 8, 2023
* Gui tests: add validation of StatusBarLabel in some tests
droidmonkey
pushed a commit
that referenced
this pull request
Feb 18, 2023
* Gui tests: add validation of StatusBarLabel in some tests
|
The gui tests from this commit are causing problems when I merged it over to the 2.7.x branch. I am going to correct them in a follow up PR. |
droidmonkey
added a commit
that referenced
this pull request
Feb 19, 2023
* Gui tests: add validation of StatusBarLabel in some tests Correct testing status bar text
droidmonkey
added a commit
that referenced
this pull request
Feb 19, 2023
* Gui tests: add validation of StatusBarLabel in some tests
|
Hm, wondering what kind of GUI test problem? |
|
The checked string is localization dependent with quantity replacements. |
Perlover
added a commit
to Perlover/keepassxc
that referenced
this pull request
May 18, 2023
Release 2.7.5 - Add menu option to allow screenshots [keepassxreboot#8841] - Add support for Botan 3 [keepassxreboot#9388] - Increase max TOTP step to 24 hours [keepassxreboot#9149] - Improve HTML export layout [keepassxreboot#8987] - Turn search reset off by default [keepassxreboot#9153] - Use QClipboard::clear() instead of setting blank text [keepassxreboot#9148] - Hide group column header choice when not in search [keepassxreboot#9171] - Improve look of KeePassXC logo and icons [keepassxreboot#9355] - Add keyboard shortcuts for app and database settings [keepassxreboot#9007] - Hide rename button from attachments preview panel [keepassxreboot#8842] - Linux: Set SingleMainWindow in .desktop file [keepassxreboot#7430] - Fix crash when search clears while creating new entry [keepassxreboot#9230] - Fix crash when using Windows Hello in a Remote Desktop session [keepassxreboot#9006] - Fix crash in Group Edit after enabling Browser Integration [keepassxreboot#8778] - Fix canceling quick unlock when it is unavailable [keepassxreboot#9034] - Set password input field font correctly [keepassxreboot#8732] - Greatly improve performance when rendering entry view [keepassxreboot#9398] - Fix various accessibility issues [keepassxreboot#9138] - Fix arrows size when expand/collapse a group [keepassxreboot#9096] - Select the clone instead of the original after cloning an entry [keepassxreboot#9070] - Fix bugs with preview widget [keepassxreboot#9170] - Fix status bar update when switching to other DB [keepassxreboot#9073] - Fix database settings spin box bug [keepassxreboot#9101] - Fix Ctrl+Tab shortcut to cycle databases in unlock dialog [keepassxreboot#8839] - Fix TOTP QR code maintaining square ratio [keepassxreboot#9027] - Fix Auto-Type configuration page on custom sequence selection [keepassxreboot#8752] - Fix unexpected behavior of `--lock` when KeePassXC is not running [keepassxreboot#8889] - Make open folder icon exempt from "Apply group icon to entry" [keepassxreboot#9205] - Allow setting default file open directory with env var [keepassxreboot#9192] - SSH Agent: Fix support for AES-256/GCM openssh keys [keepassxreboot#8968] - Browser: Fix Native Messaging script path with BSD OS's [keepassxreboot#8835] - MacOS: Fix text selection for Auto-Type clear field [keepassxreboot#9066] - MacOS: Don't rely on AppleInterfaceStyle for theme switching [keepassxreboot#8615] - Windows: Remove registry detection of desktop shortcut [keepassxreboot#9380]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9071 bug.
Testing strategy
The same as described in the bug.
Type of change