Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcuts for app and database settings #9007

Merged

Conversation

dmaslenko
Copy link
Contributor

@dmaslenko dmaslenko commented Jan 19, 2023

Fixes #8923 request to support the Ctrl+, shortcut on Linux.

Add the registration of Ctrl+, shortcut as the standard Preferences key. Refer the QT doc for details.

Screenshots

tool-menu-with-added-shortcut

Testing strategy

Tested manually on Ubuntu 22.04.1 LTS.

Type of change

  • ✅ New feature
  • ✅ Documentation

@droidmonkey
Copy link
Member

Shouldn't this open the application settings, not the database settings? Perhaps Ctrl+Shift+, can open the database settings.

@dmaslenko
Copy link
Contributor Author

Oh, the request was about app settings! Exactly.
My bad, I will double check the Ctrl+, on MacOS and then update my commit.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@5226a59). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #9007   +/-   ##
==========================================
  Coverage           ?   64.57%           
==========================================
  Files              ?      341           
  Lines              ?    44150           
  Branches           ?        0           
==========================================
  Hits               ?    28509           
  Misses             ?    15641           
  Partials           ?        0           
Impacted Files Coverage Δ
src/gui/MainWindow.cpp 71.57% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmaslenko dmaslenko changed the title Open DB settings by Ctrl+, shortcut Open app settings by Ctrl+, shortcut Jan 20, 2023
@droidmonkey droidmonkey added this to the v2.7.5 milestone Jan 29, 2023
@droidmonkey droidmonkey changed the title Open app settings by Ctrl+, shortcut Add keyboard shortcuts for app and database settings Jan 29, 2023
* Open app settings with Ctrl+,
* Open database settings with Ctrl+Shift+,
* Open database reports with Ctrl+Shift+R
@droidmonkey droidmonkey merged commit 714c0a5 into keepassxreboot:develop Jan 30, 2023
@dmaslenko dmaslenko deleted the shortcut_for_db_settings branch January 30, 2023 04:32
Perlover added a commit to Perlover/keepassxc that referenced this pull request May 18, 2023
Release 2.7.5

- Add menu option to allow screenshots [keepassxreboot#8841]
- Add support for Botan 3 [keepassxreboot#9388]
- Increase max TOTP step to 24 hours [keepassxreboot#9149]
- Improve HTML export layout [keepassxreboot#8987]
- Turn search reset off by default [keepassxreboot#9153]
- Use QClipboard::clear() instead of setting blank text [keepassxreboot#9148]
- Hide group column header choice when not in search [keepassxreboot#9171]
- Improve look of KeePassXC logo and icons [keepassxreboot#9355]
- Add keyboard shortcuts for app and database settings [keepassxreboot#9007]
- Hide rename button from attachments preview panel [keepassxreboot#8842]
- Linux: Set SingleMainWindow in .desktop file [keepassxreboot#7430]

- Fix crash when search clears while creating new entry [keepassxreboot#9230]
- Fix crash when using Windows Hello in a Remote Desktop session [keepassxreboot#9006]
- Fix crash in Group Edit after enabling Browser Integration [keepassxreboot#8778]
- Fix canceling quick unlock when it is unavailable [keepassxreboot#9034]
- Set password input field font correctly [keepassxreboot#8732]
- Greatly improve performance when rendering entry view [keepassxreboot#9398]
- Fix various accessibility issues [keepassxreboot#9138]
- Fix arrows size when expand/collapse a group [keepassxreboot#9096]
- Select the clone instead of the original after cloning an entry [keepassxreboot#9070]
- Fix bugs with preview widget [keepassxreboot#9170]
- Fix status bar update when switching to other DB [keepassxreboot#9073]
- Fix database settings spin box bug [keepassxreboot#9101]
- Fix Ctrl+Tab shortcut to cycle databases in unlock dialog [keepassxreboot#8839]
- Fix TOTP QR code maintaining square ratio [keepassxreboot#9027]
- Fix Auto-Type configuration page on custom sequence selection [keepassxreboot#8752]
- Fix unexpected behavior of `--lock` when KeePassXC is not running [keepassxreboot#8889]
- Make open folder icon exempt from "Apply group icon to entry" [keepassxreboot#9205]
- Allow setting default file open directory with env var [keepassxreboot#9192]
- SSH Agent: Fix support for AES-256/GCM openssh keys [keepassxreboot#8968]
- Browser: Fix Native Messaging script path with BSD OS's [keepassxreboot#8835]
- MacOS: Fix text selection for Auto-Type clear field [keepassxreboot#9066]
- MacOS: Don't rely on AppleInterfaceStyle for theme switching [keepassxreboot#8615]
- Windows: Remove registry detection of desktop shortcut [keepassxreboot#9380]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTRL + , to quickly open settings in Linux
3 participants