Fix wrong horizontal QR code resizing #9027
Conversation
Codecov ReportBase: 64.57% // Head: 64.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #9027 +/- ##
===========================================
+ Coverage 64.57% 64.83% +0.26%
===========================================
Files 342 342
Lines 44372 44392 +20
===========================================
+ Hits 28650 28779 +129
+ Misses 15722 15613 -109
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This doesn't solve the problem because the QR Code remains the same size. The point of resizing the window is to get a bigger qr code. |
|
Do we need that? IMHO we could even make the window a fixed size. |
|
I don't disagree. Perhaps the real problem is initial sizing of the qrcode is not dpi dependent, although it works great on my 4k screen so not sure what's the matter. |
|
Proportional resizing would be fine as well, I don't really care. |
|
I am still working to find a solution to center it or stop me here :) |
|
The next commit allows to scale and center the QR code. It looks like: Let me check if UI test is possible here... |
|
You could test by setting the dialog size and checking that the size of the qr svg is bigger and still square. |
src/gui/SquareSvgWidget.cpp
Outdated
| void SquareSvgWidget::resizeEvent(QResizeEvent*) | ||
| { | ||
| Q_ASSERT(parentWidget()); | ||
| auto containerRect = parentWidget()->contentsRect(); |
There was a problem hiding this comment.
Do a null check here, there is no guarantee the widget will have a parent and you will instacrash here if it doesn't. Assert only gets hit in debug build
There was a problem hiding this comment.
Sure, added the checking for null.
|
Hm, seems I rebased my branch incorrectlly. |
|
Added a test for QR code: |
* Also add GUI test for QR code resizing
droidmonkey
force-pushed
the
fix/qr_code_resizing
branch
from
8f74c4f
to
1ea4e2e
Compare
Release 2.7.5 - Add menu option to allow screenshots [keepassxreboot#8841] - Add support for Botan 3 [keepassxreboot#9388] - Increase max TOTP step to 24 hours [keepassxreboot#9149] - Improve HTML export layout [keepassxreboot#8987] - Turn search reset off by default [keepassxreboot#9153] - Use QClipboard::clear() instead of setting blank text [keepassxreboot#9148] - Hide group column header choice when not in search [keepassxreboot#9171] - Improve look of KeePassXC logo and icons [keepassxreboot#9355] - Add keyboard shortcuts for app and database settings [keepassxreboot#9007] - Hide rename button from attachments preview panel [keepassxreboot#8842] - Linux: Set SingleMainWindow in .desktop file [keepassxreboot#7430] - Fix crash when search clears while creating new entry [keepassxreboot#9230] - Fix crash when using Windows Hello in a Remote Desktop session [keepassxreboot#9006] - Fix crash in Group Edit after enabling Browser Integration [keepassxreboot#8778] - Fix canceling quick unlock when it is unavailable [keepassxreboot#9034] - Set password input field font correctly [keepassxreboot#8732] - Greatly improve performance when rendering entry view [keepassxreboot#9398] - Fix various accessibility issues [keepassxreboot#9138] - Fix arrows size when expand/collapse a group [keepassxreboot#9096] - Select the clone instead of the original after cloning an entry [keepassxreboot#9070] - Fix bugs with preview widget [keepassxreboot#9170] - Fix status bar update when switching to other DB [keepassxreboot#9073] - Fix database settings spin box bug [keepassxreboot#9101] - Fix Ctrl+Tab shortcut to cycle databases in unlock dialog [keepassxreboot#8839] - Fix TOTP QR code maintaining square ratio [keepassxreboot#9027] - Fix Auto-Type configuration page on custom sequence selection [keepassxreboot#8752] - Fix unexpected behavior of `--lock` when KeePassXC is not running [keepassxreboot#8889] - Make open folder icon exempt from "Apply group icon to entry" [keepassxreboot#9205] - Allow setting default file open directory with env var [keepassxreboot#9192] - SSH Agent: Fix support for AES-256/GCM openssh keys [keepassxreboot#8968] - Browser: Fix Native Messaging script path with BSD OS's [keepassxreboot#8835] - MacOS: Fix text selection for Auto-Type clear field [keepassxreboot#9066] - MacOS: Don't rely on AppleInterfaceStyle for theme switching [keepassxreboot#8615] - Windows: Remove registry detection of desktop shortcut [keepassxreboot#9380]
Fixes #8944 issue when the QR code was wrongly resized horizontally
Screenshots (have dummy QR codes based on
AAAAkey).Before
After
Testing strategy
Type of change