Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arrows size when expand/collapse a group #9096

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

dmaslenko
Copy link
Contributor

Let's have the same ratio for both vertical and horizontal direction.

Fixes #8335 user interface bug.

Screenshots

Classic style always has the same sizes:

classic-arrows

Let's have the same sizes for custom app styles:

fixed-arrows
fixed-arrows-dark

Reducing the ratio leads to have small down arrow and big right one: const qreal ArrowBaseRatio = 0.4

not-fixed-arrow

Testing strategy

  • Have an entry group(s)
  • Switch to all supported themes
  • Verify the group tree arrows

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey
Copy link
Member

The code that draws the arrow is so bad. Maybe this was the missing piece when we tried to fix the arrow size in compact mode and also tried to reduce the indent

@dmaslenko
Copy link
Contributor Author

dmaslenko commented Feb 10, 2023

The bug is reproducible in both modes.
The arrow size does not impact much on indention, few saved pixels horizontally don't play key role.
This is the compact mode:
fixed-arrows-dark-compact

If we really want to have smaller arrows we need to scale like this but keep the ratio=1:

            const qreal ArrowBaseRatio = 1.0;

...

            irw *= 0.7;
            irh *= 0.7;

Compact mode:

fixed2-arrows-dark-compact

Not compact mode:

fixed2-arrows-dark-not-compact

Let me know is it better?

@droidmonkey
Copy link
Member

No keep the arrow the original size, the ratio fix is good

Change ratio from 0.7 to 0.9 to give a more coherent look and feel to the tree.
Copy link
Member

@droidmonkey droidmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the ratio to 0.9, 1.0 produced rather pointy arrows.

@droidmonkey droidmonkey added this to the v2.7.5 milestone Feb 13, 2023
@droidmonkey droidmonkey merged commit b4be71d into keepassxreboot:develop Feb 14, 2023
@dmaslenko dmaslenko deleted the fix/arrows_size branch February 14, 2023 06:57
Perlover added a commit to Perlover/keepassxc that referenced this pull request May 18, 2023
Release 2.7.5

- Add menu option to allow screenshots [keepassxreboot#8841]
- Add support for Botan 3 [keepassxreboot#9388]
- Increase max TOTP step to 24 hours [keepassxreboot#9149]
- Improve HTML export layout [keepassxreboot#8987]
- Turn search reset off by default [keepassxreboot#9153]
- Use QClipboard::clear() instead of setting blank text [keepassxreboot#9148]
- Hide group column header choice when not in search [keepassxreboot#9171]
- Improve look of KeePassXC logo and icons [keepassxreboot#9355]
- Add keyboard shortcuts for app and database settings [keepassxreboot#9007]
- Hide rename button from attachments preview panel [keepassxreboot#8842]
- Linux: Set SingleMainWindow in .desktop file [keepassxreboot#7430]

- Fix crash when search clears while creating new entry [keepassxreboot#9230]
- Fix crash when using Windows Hello in a Remote Desktop session [keepassxreboot#9006]
- Fix crash in Group Edit after enabling Browser Integration [keepassxreboot#8778]
- Fix canceling quick unlock when it is unavailable [keepassxreboot#9034]
- Set password input field font correctly [keepassxreboot#8732]
- Greatly improve performance when rendering entry view [keepassxreboot#9398]
- Fix various accessibility issues [keepassxreboot#9138]
- Fix arrows size when expand/collapse a group [keepassxreboot#9096]
- Select the clone instead of the original after cloning an entry [keepassxreboot#9070]
- Fix bugs with preview widget [keepassxreboot#9170]
- Fix status bar update when switching to other DB [keepassxreboot#9073]
- Fix database settings spin box bug [keepassxreboot#9101]
- Fix Ctrl+Tab shortcut to cycle databases in unlock dialog [keepassxreboot#8839]
- Fix TOTP QR code maintaining square ratio [keepassxreboot#9027]
- Fix Auto-Type configuration page on custom sequence selection [keepassxreboot#8752]
- Fix unexpected behavior of `--lock` when KeePassXC is not running [keepassxreboot#8889]
- Make open folder icon exempt from "Apply group icon to entry" [keepassxreboot#9205]
- Allow setting default file open directory with env var [keepassxreboot#9192]
- SSH Agent: Fix support for AES-256/GCM openssh keys [keepassxreboot#8968]
- Browser: Fix Native Messaging script path with BSD OS's [keepassxreboot#8835]
- MacOS: Fix text selection for Auto-Type clear field [keepassxreboot#9066]
- MacOS: Don't rely on AppleInterfaceStyle for theme switching [keepassxreboot#8615]
- Windows: Remove registry detection of desktop shortcut [keepassxreboot#9380]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too big arrow pointer size in compact view
2 participants