Allow setting default file open directory with env var

[ShellCode33]

Testing strategy

Made sure the KPXC_INITIAL_DIR environment variable works as intended. This is a very minor change, I don't think adding a unit test for it would be worth it. Writing the test would actually require more core than the code itself. Plus, other environment variables are not tested either.

I did run the test suite though, everything's ok !

Type of change

• ✅ Bug fix (one of the unit tests didn't pass, I fixed it in my second commit)
• ✅ New feature (change that adds functionality)
• ✅ Documentation (non-code change)

Other

I replaced :

config()->get(Config::LastDir).toString()

with :

FileDialog::getLastDir("db")

Let me know if I shouldn't have done that, I don't know much about C++ but the .toString() felt wrong.

The FileDialog::saveLastDir() sets the Config::LastDir to a hashmap, how can a toString() work ? Plus I had to call the wrapper method getLastDir() in order to get the default directory to work, getting it from the config directly would bypass that.

keepassxc/src/gui/FileDialog.cpp

Lines 141 to 156 in 5b31288

	void FileDialog::saveLastDir(const QString& role, const QString& path, bool sensitive)
	{
	auto lastDirs = config()->get(Config::LastDir).toHash();
	if (sensitive && !config()->get(Config::RememberLastDatabases).toBool()) {
	// Ensure this role is forgotten
	lastDirs.remove(role);
	} else {
	auto pathInfo = QFileInfo(path);
	if (!pathInfo.exists()) {
	lastDirs.remove(role);
	} else {
	lastDirs.insert(role, pathInfo.absolutePath());
	}
	}
	config()->set(Config::LastDir, lastDirs);
	}

[ShellCode33]

It's weird that the CI is failing on the test I've fixed in this PR, is there some cache mecanism involved ?

""It works on my computer""

100% tests passed, 0 tests failed out of 40

[droidmonkey]

Exactly how I was thinking to implement this