Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotype: fix text selection for clear_field step on Mac #9066

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

dmaslenko
Copy link
Contributor

Screenshots

The previous key combination Ctrl + Up is assigned to show the virtual workspaces:
Screen Shot 2023-02-04 at 23 07 56

Testing strategy

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@dmaslenko dmaslenko changed the title Fix text selection for clear_field step on Mac Autotype: fix text selection for clear_field step on Mac Feb 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Base: 64.83% // Head: 64.82% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (0e0a7f7) compared to base (f703736).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9066      +/-   ##
===========================================
- Coverage    64.83%   64.82%   -0.01%     
===========================================
  Files          342      342              
  Lines        44392    44392              
===========================================
- Hits         28781    28777       -4     
- Misses       15611    15615       +4     
Impacted Files Coverage Δ
src/gui/osutils/nixutils/NixUtils.cpp 33.87% <0.00%> (-1.61%) ⬇️
src/core/Entry.cpp 82.52% <0.00%> (-0.20%) ⬇️
src/core/FileWatcher.cpp 87.95% <0.00%> (+1.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@droidmonkey droidmonkey self-requested a review February 7, 2023 11:54
Copy link
Member

@droidmonkey droidmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing META + LEFT/RIGHT it appears to be the best option.

@droidmonkey droidmonkey added this to the v2.7.5 milestone Feb 7, 2023
@droidmonkey droidmonkey merged commit bba0c09 into keepassxreboot:develop Feb 7, 2023
@dmaslenko dmaslenko deleted the fix/clear_field_mac branch February 8, 2023 05:29
Perlover added a commit to Perlover/keepassxc that referenced this pull request May 18, 2023
Release 2.7.5

- Add menu option to allow screenshots [keepassxreboot#8841]
- Add support for Botan 3 [keepassxreboot#9388]
- Increase max TOTP step to 24 hours [keepassxreboot#9149]
- Improve HTML export layout [keepassxreboot#8987]
- Turn search reset off by default [keepassxreboot#9153]
- Use QClipboard::clear() instead of setting blank text [keepassxreboot#9148]
- Hide group column header choice when not in search [keepassxreboot#9171]
- Improve look of KeePassXC logo and icons [keepassxreboot#9355]
- Add keyboard shortcuts for app and database settings [keepassxreboot#9007]
- Hide rename button from attachments preview panel [keepassxreboot#8842]
- Linux: Set SingleMainWindow in .desktop file [keepassxreboot#7430]

- Fix crash when search clears while creating new entry [keepassxreboot#9230]
- Fix crash when using Windows Hello in a Remote Desktop session [keepassxreboot#9006]
- Fix crash in Group Edit after enabling Browser Integration [keepassxreboot#8778]
- Fix canceling quick unlock when it is unavailable [keepassxreboot#9034]
- Set password input field font correctly [keepassxreboot#8732]
- Greatly improve performance when rendering entry view [keepassxreboot#9398]
- Fix various accessibility issues [keepassxreboot#9138]
- Fix arrows size when expand/collapse a group [keepassxreboot#9096]
- Select the clone instead of the original after cloning an entry [keepassxreboot#9070]
- Fix bugs with preview widget [keepassxreboot#9170]
- Fix status bar update when switching to other DB [keepassxreboot#9073]
- Fix database settings spin box bug [keepassxreboot#9101]
- Fix Ctrl+Tab shortcut to cycle databases in unlock dialog [keepassxreboot#8839]
- Fix TOTP QR code maintaining square ratio [keepassxreboot#9027]
- Fix Auto-Type configuration page on custom sequence selection [keepassxreboot#8752]
- Fix unexpected behavior of `--lock` when KeePassXC is not running [keepassxreboot#8889]
- Make open folder icon exempt from "Apply group icon to entry" [keepassxreboot#9205]
- Allow setting default file open directory with env var [keepassxreboot#9192]
- SSH Agent: Fix support for AES-256/GCM openssh keys [keepassxreboot#8968]
- Browser: Fix Native Messaging script path with BSD OS's [keepassxreboot#8835]
- MacOS: Fix text selection for Auto-Type clear field [keepassxreboot#9066]
- MacOS: Don't rely on AppleInterfaceStyle for theme switching [keepassxreboot#8615]
- Windows: Remove registry detection of desktop shortcut [keepassxreboot#9380]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-Type {CLEARFIELD} is not working on 2.7.4 (Repeat of #6463)
3 participants